Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RxJS contributing | Update docs for withCredentials #3448

Closed
james-dowell opened this issue Mar 19, 2018 · 3 comments
Closed

RxJS contributing | Update docs for withCredentials #3448

james-dowell opened this issue Mar 19, 2018 · 3 comments

Comments

@james-dowell
Copy link
Contributor

james-dowell commented Mar 19, 2018

Hey peeps,

I've noticed that the withCredentials property is missing from the AjaxRequest docs but was added in #1758 and is in the TS definitions.

Seems like a minor oversight so I've updated the docs locally (using the contributing guidelines).. and was going to create a PR but doesn't look like I can push to the repo (permissions). Not done much open source contributing before so apologies if I'm doing something stupid.

Could someone give me permission to push/correct me or perhaps update the docs for me?

Big fan of RxJS!

Cheers,

James

@cartant
Copy link
Collaborator

cartant commented Mar 19, 2018

Hey, James.

You'll need to make the changes to a forked repo; not to a clone of this repo.

There is a good explanation of the procedure and related workflows here.

@james-dowell
Copy link
Contributor Author

Thanks @cartant!

@lock
Copy link

lock bot commented Jun 5, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants