Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ajax regression in 7.0.0-beta.11: default responseType has changed from 'json' to '' #6052

Closed
OliverJAsh opened this issue Feb 26, 2021 · 1 comment
Closed

ajax regression in 7.0.0-beta.11: default responseType has changed from 'json' to '' #6052

OliverJAsh opened this issue Feb 26, 2021 · 1 comment
Assignees
@benlesh
Labels
bug Confirmed bug

Comments

@OliverJAsh
Copy link
Contributor

OliverJAsh commented Feb 26, 2021 •
edited
Loading

Bug Report

Current Behavior
873e52d#diff-700d20a43f740146f5a6f8544b7035b0d0a03d074d7fa1d551a9b44977effa1fL318-R323

  • 7.0.0-beta.10: responseType: 'json' as XMLHttpRequestResponseType,
  • 7.0.0-beta.11: responseType: '' as XMLHttpRequestResponseType,

Because of this change, my JSON responses are no longer parsed to JSON.

To workaround this I have to specify responseType: 'json' manually when calling ajax.

I believe this is not intended because it was not mentioned in the changelog as a known breaking change.
@benlesh benlesh added the bug Confirmed bug label Feb 26, 2021
@benlesh benlesh self-assigned this Feb 26, 2021
@benlesh
Copy link
Member

benlesh commented Feb 26, 2021

It looks like this was missed because the test harness was incorrectly setting responseType on the XHR mock during the return. That doesn't happen in the real XHR.

benlesh added a commit to benlesh/rxjs that referenced this issue Feb 26, 2021
@benlesh
fix(ajax): Ensure that responseType defaults to "json"
422af8e 
- Updates tests to be more accurate

Resolves ReactiveX#6052
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benlesh benlesh

Labels
bug Confirmed bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OliverJAsh @benlesh