You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make rxjs side-effect-free to take advantage of Webpack 4 and significantly decrease application bundle sizes
Adds an rxjs-compat package to be separately distributed to NPM
rxjs-compat holds imports that produce side-effects (any code that monkey patches through add operator will live here)
Adds a legacy-reexports directory used at build time to make imports such as rxjs/Observable still work (though devs will need to install rxjs-compat to make these imports behave correctly)
Basically, this makes the default case for Rx side-effect free, but includes many breaking API changes. The rxjs-compat package mitigates these breaking changes.
So is rxjs-compatbecause of "sideEffects": false, or is that an excuse for it? Because with webpack 4.0.1 you could instead use something like "sideEffects": ["add/**", ...]...
@simonbuchan Intriguing note there. I can't find that anywhere in Webpack docs, and WebpackOptions.json says that option is a boolean. Can you point me to what you're referring to?
@simonbuchan Also, there is a reason for the rxjs-compat package. This is so users will have to take explicit action to get the old behavior, thus opting in.
Huh, is a very recent change, but it's not even mentioned in the release changelog. Here's the PR: webpack/webpack#6536
Perhaps deemed not ready for primetime?
Re. rxjs-compat, what I meant was would you want to make these breaking changes if you didn't have to for sideEffects? Sounds like you do, I'm mostly neutral so long as we have less duplicate import names confusing IDEs.
(1) : Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.
jasonaden
changed the title
WIP: Side effect free imports & backwards compatibility APIs
Side effect free imports & backwards compatibility APIs
Mar 16, 2018
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
lockbot
locked as resolved and limited conversation to collaborators
Jun 6, 2018
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jasonaden
force-pushed
the
side-effect-free-imports
branch
2 times, most recently
from
This PR will address a couple things at once:
rxjsside-effect-free to take advantage of Webpack 4 and significantly decrease application bundle sizesrxjs-compatpackage to be separately distributed to NPMrxjs-compatholds imports that produce side-effects (any code that monkey patches throughaddoperator will live here)legacy-reexportsdirectory used at build time to make imports such asrxjs/Observablestill work (though devs will need to installrxjs-compatto make these imports behave correctly)Basically, this makes the default case for Rx side-effect free, but includes many breaking API changes. The
rxjs-compatpackage mitigates these breaking changes.