Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(delayWhen-spec): update delayWhen operator tests to use pipeable operators #3682

Merged
merged 1 commit into from
May 21, 2018

Conversation

natmegs
Copy link
Collaborator

@natmegs natmegs commented May 10, 2018

update delayWhen spec to use updated import sites and pipeable operators

…able operators

update delayWhen spec to use updated import sites and pipeable operators
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.833% when pulling e9eaa74 on natmegs:delaywhen-spec-pipeable into dc66731 on ReactiveX:master.

@Airblader
Copy link
Contributor

This is also done in #3664 already.

@benlesh
Copy link
Member

benlesh commented May 21, 2018

@Airblader, that's great, but I think it would be better if we did this in two steps. I'll merge this one, then you'll need to rebase yours, is that okay?

@benlesh benlesh merged commit afee54a into ReactiveX:master May 21, 2018
@benlesh
Copy link
Member

benlesh commented May 21, 2018

thanks again, @natmegs!

@lock lock bot locked as resolved and limited conversation to collaborators Jun 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants