Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(groupBy): Update to groupBy docs #4036

Merged
merged 1 commit into from
Aug 20, 2018

Conversation

pertrai1
Copy link
Contributor

Description:

Modifications that update the docs for groupBy from the older docs to the newer.

Related issue (if exists):

related issue: #4029

@pertrai1 pertrai1 force-pushed the groupBy-docs-update branch from 926001f to 545df13 Compare August 18, 2018 16:21
@coveralls
Copy link

coveralls commented Aug 18, 2018

Coverage Status

Coverage remained the same at 96.947% when pulling ec49fcf on pertrai1:groupBy-docs-update into 030eee7 on ReactiveX:master.

Copy link
Member

@niklas-wortmann niklas-wortmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome PR, well done. Here's just on minor change requested

* // [ { id: 1, name: 'aze1' },
* // { id: 1, name: 'erg1' },
* // { id: 1, name: 'df1' } ]
* // [ { id: 1, name: 'javascript'},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We try to have short api examples, so that you get the way this operator works as fast as possible. Maybe you can shorten it a bit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwo719 I have shorted and fixed the first example as well.

@pertrai1 pertrai1 force-pushed the groupBy-docs-update branch from 545df13 to ec49fcf Compare August 19, 2018 17:55
Copy link
Member

@niklas-wortmann niklas-wortmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much

@cartant cartant merged commit 9be9cae into ReactiveX:master Aug 20, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Sep 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants