From eda49687370fa8e7faeeb0230f8b76cd3dd01a24 Mon Sep 17 00:00:00 2001 From: Moshe Kolodny Date: Fri, 20 Sep 2019 17:14:33 -0400 Subject: [PATCH 1/3] Update of.ts Remove valid use of `of` --- src/internal/observable/of.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/internal/observable/of.ts b/src/internal/observable/of.ts index ee76acd39f..e1a13152ce 100644 --- a/src/internal/observable/of.ts +++ b/src/internal/observable/of.ts @@ -34,7 +34,6 @@ export function of(a: T, b: T2, c: T3, d: T4, export function of(): Observable; /** @deprecated remove in v8. Do not use generic arguments directly, allow inference or cast with `as` */ export function of(): Observable; -/** @deprecated remove in v8. Do not use generic arguments directly, allow inference or cast with `as` */ export function of(value: T): Observable; export function of>(...args: A): Observable>; /* tslint:enable:max-line-length */ From c2c0032e8460190ec77d7e86a9d06b243c044646 Mon Sep 17 00:00:00 2001 From: Moshe Kolodny Date: Sun, 22 Sep 2019 21:36:54 -0400 Subject: [PATCH 2/3] reorder overloads instead --- src/internal/observable/of.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/internal/observable/of.ts b/src/internal/observable/of.ts index e1a13152ce..28de920637 100644 --- a/src/internal/observable/of.ts +++ b/src/internal/observable/of.ts @@ -32,10 +32,11 @@ export function of(a: T, b: T2, c: T3, d: T4, // TODO(benlesh): Update the typings for this when we can switch to TS 3.x export function of(): Observable; +export function of>(...args: A): Observable>; /** @deprecated remove in v8. Do not use generic arguments directly, allow inference or cast with `as` */ export function of(): Observable; +/** @deprecated remove in v8. Do not use generic arguments directly, allow inference or cast with `as` */ export function of(value: T): Observable; -export function of>(...args: A): Observable>; /* tslint:enable:max-line-length */ /** From cf9e96f68aa22bcb91ec1bb4c3292e31091b4864 Mon Sep 17 00:00:00 2001 From: Moshe Kolodny Date: Thu, 10 Oct 2019 20:53:00 -0400 Subject: [PATCH 3/3] removed deprecated tag and added more generic overloads --- src/internal/observable/of.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/internal/observable/of.ts b/src/internal/observable/of.ts index 28de920637..05226c36bf 100644 --- a/src/internal/observable/of.ts +++ b/src/internal/observable/of.ts @@ -32,11 +32,12 @@ export function of(a: T, b: T2, c: T3, d: T4, // TODO(benlesh): Update the typings for this when we can switch to TS 3.x export function of(): Observable; -export function of>(...args: A): Observable>; /** @deprecated remove in v8. Do not use generic arguments directly, allow inference or cast with `as` */ export function of(): Observable; -/** @deprecated remove in v8. Do not use generic arguments directly, allow inference or cast with `as` */ export function of(value: T): Observable; +export function of(value1: T, value2: U): Observable; +export function of(value1: T, value2: U, value3: V): Observable; +export function of>(...args: A): Observable>; /* tslint:enable:max-line-length */ /**