refactor: Predicate types #5842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josepot
reviewed
Oct 20, 2020
cartant
requested changes
Oct 23, 2020
benlesh
force-pushed
the
refactor/predicate-typings
branch
from
c1a1e3c to
3b772c4
Compare
cartant
requested changes
Oct 25, 2020
Update operators with predicates to properly handle typings with `Boolean` constructor and predicates that return either always `true` or always `false`, depending on the operator. - Updates dtslint tests.
- Every now infers correctly when `Boolean` constructor is used.
benlesh
force-pushed
the
refactor/predicate-typings
branch
from
b84ee00 to
9092e09
Compare
|
Rebased as well. |
cartant
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update operators with predicates to properly handle typings with
Booleanconstructor and predicates that return either alwaystrueor alwaysfalse, depending on the operator.Related #5831