Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating /users/self GET route #1988

Closed
1 of 10 tasks
somu-code opened this issue Mar 26, 2024 · 1 comment
Closed
1 of 10 tasks

Deprecating /users/self GET route #1988

somu-code opened this issue Mar 26, 2024 · 1 comment
Assignees

Comments

@somu-code
Copy link

somu-code commented Mar 26, 2024

Issue Description

Deprecate the/users/self API from website-backend. And adding a new route that will serve the purpose of /users/self.
Old issue link

Expected Behavior

The user's data should return from an API that has some meaningful name.

Current Behavior

Currently, /users/self GET route returns all the details of the currently authenticated user.

User Story

  • As a user, I want to access my details and tasks details without relying on a generic endpoint, ensuring a more personalized and secure experience.

Developer Story

  • As a developer, I want to ensure the API remains efficient and easy to maintain as the user base grows.

Requirements

  • Delete /users/self endpoint.
  • We will be needing a new route that will server the purpose of /users/self.
  • Either we can use /users resource with a query param(id), something like /users?id=some_id, or can create new endpoints like /users/me or /users/profile.

Screenshots

/users/self

Screenshot from 2024-05-17 13-28-38

/users?id=66wkaNSpTskaVTmSSRPQ

Screenshot from 2024-06-16 00-43-05

Reproducibility

  • This issue is reproducible
  • This issue is not reproducible

Steps to Reproduce

  1. Make a GET request to /users/self and /users?id=some_id endpoints.

Severity/Priority

  • Critical
  • High
  • Medium
  • Low

Additional Information

Checklist

  • I have read and followed the project's code of conduct.
  • I have searched for similar issues before creating this one.
  • I have provided all the necessary information to understand and reproduce the issue.
  • I am willing to contribute to the resolution of this issue.
@somu-code somu-code mentioned this issue May 16, 2024
10 tasks
@somu-code somu-code changed the title Deprecating tasks self API Replacing /self API with search query params May 17, 2024
@somu-code somu-code changed the title Replacing /self API with search query params Deprecating /users/self GET route Jun 15, 2024
@vikasosmium
Copy link
Contributor

Hello @vinit717
Could you please close this issue? I've completed the tasks listed below, and they have been merged.

New Route - #2201
Header Warning - #2221
API Contract - Real-Dev-Squad/website-api-contracts#191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants