Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update apiKey in to be titleize #902

Merged
merged 3 commits into from
May 12, 2019
Merged

fix: update apiKey in to be titleize #902

merged 3 commits into from
May 12, 2019

Conversation

cfabianski
Copy link
Contributor

fixes #880

@coveralls
Copy link

coveralls commented Apr 30, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 81.763% when pulling 1eef4c0 on cfabianski:fix-api-key-in-titleization into 5dd5d6d on Rebilly:master.

RomanHotsiy
RomanHotsiy requested changes May 6, 2019
View reviewed changes
Copy link
Member

@RomanHotsiy RomanHotsiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you create a titleize function in utils/helpers.ts and use it here?

@cfabianski
Copy link
Contributor Author

@RomanGotsiy Is that better?

@RomanHotsiy RomanHotsiy merged commit 35df477 into Redocly:master May 12, 2019
@RomanHotsiy
Copy link
Member

Much better! Thanks!

@cfabianski cfabianski deleted the fix-api-key-in-titleization branch May 12, 2019 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomanHotsiy RomanHotsiy RomanHotsiy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Capitalize first letter of the "in" value in apiKey Security scheme
3 participants
@cfabianski @coveralls @RomanHotsiy