Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rhelServices,rhelGraphCard): issues/79 hypervisor api #121

Merged
merged 1 commit into from
Nov 5, 2019

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Nov 5, 2019

What's included

  • feat(rhelServices,rhelGraphCard): issues/79 hypervisor api
    • rhelGraphCard, minor fix, flip capacity to sockets from physical
    • rhelServices, restructure mocks for hypervisor updates
    • rhelApiTypes, capacity and products hypervisor sockets breakout
    • tests, add socket facets to helpers, graphCard, selectors, types

Notes

  • This is a incremental update while the GUI is converted towards displaying the Hypervisor aspect of the RHSM API properties.
  • Minor fix for threshold/capacity shifted towards using the total sockets instead of just physical sockets

How to test

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start
  3. No visual changes should be detectable. And no console errors should be present

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. No visual changes should be detectable. And no console errors should be present

Example

...

Updates issue/story

Updates #79

…ights#121)

* rhelGraphCard, minor fix, flip capacity to sockets from physical
* rhelServices, restructure mocks for hypervisor updates
* rhelApiTypes, capacity and products hypervisor sockets breakout
* tests, add socket facets to helpers, graphCard, selectors, types
@codecov-io
Copy link

Codecov Report

Merging #121 into ci will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               ci     #121   +/-   ##
=======================================
  Coverage   91.28%   91.28%           
=======================================
  Files          27       27           
  Lines         562      562           
  Branches      148      148           
=======================================
  Hits          513      513           
  Misses         39       39           
  Partials       10       10
Impacted Files Coverage Δ
src/components/rhelGraphCard/rhelGraphCard.js 67.74% <ø> (ø) ⬆️
src/types/rhelApiTypes.js 100% <ø> (ø) ⬆️
src/services/rhelServices.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dc4eaa...bd1c87c. Read the comment docs.

@cdcabrera cdcabrera merged commit 479f05d into RedHatInsights:ci Nov 5, 2019
cdcabrera added a commit that referenced this pull request Nov 15, 2019
* rhelGraphCard, minor fix, flip capacity to sockets from physical
* rhelServices, restructure mocks for hypervisor updates
* rhelApiTypes, capacity and products hypervisor sockets breakout
* tests, add socket facets to helpers, graphCard, selectors, types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants