Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix, apply unique queries for API endpoints Issues/380 #381

Merged
merged 2 commits into from
Aug 20, 2020

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Aug 20, 2020

What's included

  • fix(rhsmApiTypes): issues/380 api query types

    • rhsmApiTypes, apply api query types for individual api calls
    • graphCard, c3, types updates, centralize getQuery
    • rhelView, openshiftView, types updates
    • redux, actions, selectors, reducer, types updates
  • fix(apiQueries,reduxHelpers): issues/380 query schema

    • apiQueries, reduxHelpers, parse queries for specific API endpoints
    • openshiftView, rhelView, apply parseRhsmQuery

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. Open the browser dev console, select network, clear it. Then select a "per page limit". Confirm that the only XHR call that fires is for "hosts"/inventory and no longer updates the graph beyond a slight appearance refresh (that's a separate issue =) ). The intended behaviors are...
    • Selecting inventory paging facets should only affect updating inventory, and the associated XHR call
    • Selecting graph granularity should only affect updating the graph display, and associated XHR calls
    • Selecting a toolbar filter should affect both the graph and inventory displays, and associated XHR calls

Example

...

Updates issue/story

updates #380
updates #10

* rhsmApiTypes, apply api query types for individual api calls
* graphCard, c3, types updates, centralize getQuery
* rhelView, openshiftView, types updates
* redux, actions, selectors, reducer, types updates
…#381)

* apiQueries, reduxHelpers, parse queries for specific API endpoints
* openshiftView, rhelView, apply parseRhsmQuery
@codecov-commenter
Copy link

Codecov Report

Merging #381 into ci will decrease coverage by 0.00%.
The diff coverage is 97.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##               ci     #381      +/-   ##
==========================================
- Coverage   92.48%   92.48%   -0.01%     
==========================================
  Files          67       68       +1     
  Lines        1637     1649      +12     
  Branches      376      381       +5     
==========================================
+ Hits         1514     1525      +11     
  Misses        108      108              
- Partials       15       16       +1     
Impacted Files Coverage Δ
src/components/toolbar/toolbar.js 91.07% <ø> (ø)
src/components/toolbar/toolbarTypes.js 100.00% <ø> (ø)
src/redux/reducers/viewReducer.js 100.00% <ø> (ø)
src/redux/selectors/viewSelectors.js 100.00% <ø> (ø)
src/redux/types/queryTypes.js 100.00% <ø> (ø)
src/redux/common/reduxHelpers.js 92.85% <88.88%> (-0.31%) ⬇️
src/components/c3GraphCard/c3GraphCard.js 89.09% <100.00%> (+0.41%) ⬆️
src/components/graphCard/graphCard.js 84.31% <100.00%> (+0.64%) ⬆️
src/components/inventoryList/inventoryList.js 88.88% <100.00%> (ø)
src/components/openshiftView/openshiftView.js 97.05% <100.00%> (+0.08%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 776ac29...6b05ebf. Read the comment docs.

@cdcabrera cdcabrera merged commit 147bbcd into RedHatInsights:ci Aug 20, 2020
cdcabrera added a commit that referenced this pull request Aug 20, 2020
* rhsmApiTypes, apply api query types for individual api calls
* graphCard, c3, types updates, centralize getQuery
* rhelView, openshiftView, types updates
* redux, actions, selectors, reducer, types updates
cdcabrera added a commit that referenced this pull request Aug 25, 2020
* rhsmApiTypes, apply api query types for individual api calls
* graphCard, c3, types updates, centralize getQuery
* rhelView, openshiftView, types updates
* redux, actions, selectors, reducer, types updates
cdcabrera added a commit that referenced this pull request Aug 25, 2020
* apiQueries, reduxHelpers, parse queries for specific API endpoints
* openshiftView, rhelView, apply parseRhsmQuery
cdcabrera added a commit that referenced this pull request Aug 25, 2020
* rhsmApiTypes, apply api query types for individual api calls
* graphCard, c3, types updates, centralize getQuery
* rhelView, openshiftView, types updates
* redux, actions, selectors, reducer, types updates
cdcabrera added a commit that referenced this pull request Aug 25, 2020
* apiQueries, reduxHelpers, parse queries for specific API endpoints
* openshiftView, rhelView, apply parseRhsmQuery
cdcabrera added a commit that referenced this pull request Sep 16, 2020
* rhsmApiTypes, apply api query types for individual api calls
* graphCard, c3, types updates, centralize getQuery
* rhelView, openshiftView, types updates
* redux, actions, selectors, reducer, types updates
cdcabrera added a commit that referenced this pull request Sep 16, 2020
* apiQueries, reduxHelpers, parse queries for specific API endpoints
* openshiftView, rhelView, apply parseRhsmQuery
cdcabrera added a commit that referenced this pull request Sep 29, 2020
* rhsmApiTypes, apply api query types for individual api calls
* graphCard, c3, types updates, centralize getQuery
* rhelView, openshiftView, types updates
* redux, actions, selectors, reducer, types updates
cdcabrera added a commit that referenced this pull request Sep 29, 2020
* apiQueries, reduxHelpers, parse queries for specific API endpoints
* openshiftView, rhelView, apply parseRhsmQuery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants