Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inventoryList): issues/403 adjust for expanded guestsList #460

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(inventoryList): issues/403 adjust for expanded guestsList
    • graphCard, remove default minHeight prop
    • inventoryList, autoUpdate prop
    • minHeight, flip autoUpdate, inner container height for reset

Notes

  • re-adjusts minHeight for a "more pleasant" paging experience when expanding the guestsList inventory display.
    • Currently when a guestsList inventory is expanded that height is applied to the overall "min-height" causing subsequently paged inventory displays to maintain the expanded guestsList display height. This patch aids in a "reset" for said scenario

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. Locate an account with inventory and guests listings
  5. expand a guests lists inventory display
  6. page to a next page, the paging should readjust its height instead of maintaining the expanded guests list height

Example

...

Updates issue/story

#403

* graphCard, remove default minHeight prop
* inventoryList, autoUpdate prop
* minHeight, flip autoUpdate, inner container height for reset
@codecov-io
Copy link

Codecov Report

Merging #460 into ci will increase coverage by 0.05%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##               ci     #460      +/-   ##
==========================================
+ Coverage   92.99%   93.05%   +0.05%     
==========================================
  Files          70       70              
  Lines        1828     2203     +375     
  Branches      427      707     +280     
==========================================
+ Hits         1700     2050     +350     
- Misses        111      135      +24     
- Partials       17       18       +1     
Impacted Files Coverage Δ
src/components/graphCard/graphCard.js 86.66% <ø> (+2.35%) ⬆️
src/components/inventoryList/inventoryList.js 90.90% <ø> (-3.69%) ⬇️
src/components/minHeight/minHeight.js 97.87% <66.66%> (+0.43%) ⬆️
src/components/router/redirect.js 65.00% <0.00%> (-5.59%) ⬇️
src/components/router/routerHelpers.js 91.42% <0.00%> (-5.45%) ⬇️
src/services/platformServices.js 97.36% <0.00%> (-2.64%) ⬇️
src/redux/selectors/inventoryListSelectors.js 97.43% <0.00%> (-2.57%) ⬇️
src/redux/selectors/graphCardSelectors.js 98.21% <0.00%> (-1.79%) ⬇️
src/components/graphCard/graphCardHelpers.js 98.61% <0.00%> (-1.39%) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4e3510...adab7dd. Read the comment docs.

@cdcabrera cdcabrera merged commit e8d1e44 into RedHatInsights:ci Oct 13, 2020
cdcabrera added a commit that referenced this pull request Oct 13, 2020
* graphCard, remove default minHeight prop
* inventoryList, autoUpdate prop
* minHeight, flip autoUpdate, inner container height for reset
cdcabrera added a commit that referenced this pull request Oct 13, 2020
* graphCard, remove default minHeight prop
* inventoryList, autoUpdate prop
* minHeight, flip autoUpdate, inner container height for reset
cdcabrera added a commit that referenced this pull request Oct 13, 2020
* graphCard, remove default minHeight prop
* inventoryList, autoUpdate prop
* minHeight, flip autoUpdate, inner container height for reset
cdcabrera added a commit that referenced this pull request Oct 14, 2020
* graphCard, remove default minHeight prop
* inventoryList, autoUpdate prop
* minHeight, flip autoUpdate, inner container height for reset
cdcabrera added a commit that referenced this pull request Oct 26, 2020
* graphCard, remove default minHeight prop
* inventoryList, autoUpdate prop
* minHeight, flip autoUpdate, inner container height for reset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants