feat(locale): use cookie to determine current locale #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priley86
changed the title
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
+ Coverage 86.68% 87.11% +0.42%
==========================================
Files 23 23
Lines 293 295 +2
Branches 60 62 +2
==========================================
+ Hits 254 257 +3
+ Misses 31 30 -1
Partials 8 8
Continue to review full report at Codecov.
|
cdcabrera
requested changes
Jul 25, 2019
|
how long does this travis build go? I'm still clicking "cookies" over here 😸 |
cdcabrera
approved these changes
Jul 29, 2019
* use rh_locale cookie to set i18n locale if it's available * use env var as a fallback if we can't find a supported locale * gitignore, added en-US locale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Valid i18n codes (and major codes):
https://github.com/ladjs/i18n-locales#tip
How to test
$ yarn$ yarn test:devExample
.
Updates issue/story
closes #44