Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inventoryList): issues/476 hide field on zero results #555

Merged
merged 2 commits into from
Jan 20, 2021

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(inventoryList): issues/476 hide field on zero results
  • fix(inventoryList): consistent hide, aria-hidden attributes

    • inventoryList, subsInventoryList, consistent hide, aria-hidden
    • pagination, consistent hide, aria-hidden

Notes

  • minor UX adjustment, hide the display name search when there are no results

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. log in with an account known to have zero results for one of its host inventory displays
  5. upon see no results confirm the display name field is hidden

Example

with

Screen Shot 2021-01-19 at 5 50 39 PM

without

Screen Shot 2021-01-19 at 5 50 23 PM

Updates issue/story

#476

@cdcabrera cdcabrera force-pushed the issues/476-displayname branch from 0a17fdb to 6c20f9e Compare January 20, 2021 00:18
@cdcabrera cdcabrera merged commit b693fb7 into RedHatInsights:ci Jan 20, 2021
cdcabrera added a commit that referenced this pull request Jan 27, 2021
* inventoryList, subsInventoryList, consistent hide, aria-hidden
* pagination, consistent hide, aria-hidden
cdcabrera added a commit that referenced this pull request Feb 1, 2021
* inventoryList, subsInventoryList, consistent hide, aria-hidden
* pagination, consistent hide, aria-hidden
cdcabrera added a commit that referenced this pull request Feb 16, 2021
* inventoryList, subsInventoryList, consistent hide, aria-hidden
* pagination, consistent hide, aria-hidden
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant