Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): patch local dev run, without proxy #585

Merged
merged 3 commits into from
Feb 16, 2021

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(guestsList): column widths for loader
  • fix(table): additional cell content type
  • chore(build): patch local dev run, without proxy

    • build, chrome2 setup melts if browserslist malformed in package.json

Notes

  • Chrome 2 updates are affected by a malformed package.json "browserlist" prop. We checked in the base browserlist setup from CRA and added an error message if the Chrome 2 build fails.
    • In the future the Chrome may stop working entirely with our current setup. In that event we have a fallback solution of just using placeholder code along with the base platform styles

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests pass

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm integration tests pass

Example

...

Updates issue/story

Ongoing

@cdcabrera cdcabrera changed the title fix(guestsList): column widths for loader chore(build): patch local dev run, without proxy Feb 16, 2021
@cdcabrera cdcabrera added 202104 project phase platform Contains, or is, platform specific work and issues tech debt We've ignored it this long... labels Feb 16, 2021
@cdcabrera cdcabrera merged commit 89a2436 into RedHatInsights:ci Feb 16, 2021
cdcabrera added a commit that referenced this pull request Mar 5, 2021
* build, chrome2 melts if browserslist malformed in package.json
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 24, 2021
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 24, 2021
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 24, 2021
* build, chrome2 melts if browserslist malformed in package.json
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 25, 2021
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 25, 2021
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 25, 2021
* build, chrome2 melts if browserslist malformed in package.json
cdcabrera added a commit that referenced this pull request Mar 25, 2021
* build, chrome2 melts if browserslist malformed in package.json
cdcabrera added a commit that referenced this pull request Apr 13, 2021
* build, chrome2 melts if browserslist malformed in package.json
cdcabrera added a commit that referenced this pull request Apr 13, 2021
* build, chrome2 melts if browserslist malformed in package.json
cdcabrera added a commit that referenced this pull request Apr 20, 2021
* build, chrome2 melts if browserslist malformed in package.json
cdcabrera added a commit that referenced this pull request Apr 26, 2021
* build, chrome2 melts if browserslist malformed in package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202104 project phase platform Contains, or is, platform specific work and issues tech debt We've ignored it this long...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant