Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(viewReducer): ent-3509 date range for inventory #597

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Mar 6, 2021

What's included

  • fix(viewReducer): ent-3509 date range for inventory
    • productView(s), propTypes, default props for date ranges
    • rhsmApiTypes, query check, include beginning, ending params
    • viewReducer, move date range to global query

Notes

  • dependent on chore(build): npm updates #598
  • applies the date range query params associated with granularity towards inventory component(s)
  • this update alters loading behavior for the inventory components on products outside of OpenShift OCP and Dedicated. now when a user selects granularity it will reload/redraw the graph and the inventory components unless cached
    • as an iteration task we may want to consider applying a product level config filter that handles unique query scenarios

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. granularity like updates now affect inventory displays, any product can be confirmed, however the catalyst for this update is the OpenShift Container Platform view
    • navigate to OpenShift Container Platform
    • In the right column, confirm selecting a month updates the date range for the host inventory display
      • Opening the dev browser console will highlight the query params being applied

Example

...

Updates issue/story

ent-3509
ent-3507
ent-3324

@codecov-io
Copy link

codecov-io commented Mar 6, 2021

Codecov Report

Merging #597 (87c1fab) into ci (175706a) will decrease coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               ci     #597      +/-   ##
==========================================
- Coverage   93.87%   93.70%   -0.18%     
==========================================
  Files          86       86              
  Lines        2140     2590     +450     
  Branches      540      899     +359     
==========================================
+ Hits         2009     2427     +418     
- Misses        108      140      +32     
  Partials       23       23              
Impacted Files Coverage Δ
src/components/productView/productView.js 100.00% <ø> (ø)
...nents/productView/productViewOpenShiftContainer.js 72.72% <ø> (-4.83%) ⬇️
...nents/productView/productViewOpenShiftDedicated.js 94.44% <ø> (-5.56%) ⬇️
src/components/productView/productViewRhel.js 91.42% <ø> (-0.24%) ⬇️
src/components/productView/productViewSatellite.js 91.42% <ø> (-0.24%) ⬇️
src/redux/reducers/viewReducer.js 100.00% <ø> (ø)
src/types/rhsmApiTypes.js 100.00% <ø> (ø)
...rc/components/toolbar/toolbarFieldRangedMonthly.js 100.00% <100.00%> (+9.09%) ⬆️
src/components/router/redirect.js 65.00% <0.00%> (-5.59%) ⬇️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 175706a...87c1fab. Read the comment docs.

@cdcabrera cdcabrera force-pushed the ent-3509-date-range branch from 7f4c83e to 87c1fab Compare March 8, 2021 17:10
@cdcabrera cdcabrera marked this pull request as ready for review March 8, 2021 17:10
@cdcabrera cdcabrera added 202104 project phase story New feature, or process work labels Mar 9, 2021
* productView(s), propTypes, default props for date ranges
* rhsmApiTypes, query check, include beginning, ending params
* viewReducer, move date range to global query
@cdcabrera cdcabrera force-pushed the ent-3509-date-range branch from 87c1fab to a7b3f31 Compare March 9, 2021 19:54
@cdcabrera cdcabrera merged commit 55915b5 into RedHatInsights:ci Mar 9, 2021
cdcabrera added a commit that referenced this pull request Mar 16, 2021
* productView(s), propTypes, default props for date ranges
* rhsmApiTypes, query check, include beginning, ending params
* viewReducer, move date range to global query
cdcabrera added a commit that referenced this pull request Mar 16, 2021
* productView(s), propTypes, default props for date ranges
* rhsmApiTypes, query check, include beginning, ending params
* viewReducer, move date range to global query
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 24, 2021
* productView(s), propTypes, default props for date ranges
* rhsmApiTypes, query check, include beginning, ending params
* viewReducer, move date range to global query
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 25, 2021
* productView(s), propTypes, default props for date ranges
* rhsmApiTypes, query check, include beginning, ending params
* viewReducer, move date range to global query
cdcabrera added a commit that referenced this pull request Mar 25, 2021
* productView(s), propTypes, default props for date ranges
* rhsmApiTypes, query check, include beginning, ending params
* viewReducer, move date range to global query
cdcabrera added a commit that referenced this pull request Apr 13, 2021
* productView(s), propTypes, default props for date ranges
* rhsmApiTypes, query check, include beginning, ending params
* viewReducer, move date range to global query
cdcabrera added a commit that referenced this pull request Apr 13, 2021
* productView(s), propTypes, default props for date ranges
* rhsmApiTypes, query check, include beginning, ending params
* viewReducer, move date range to global query
cdcabrera added a commit that referenced this pull request Apr 20, 2021
* productView(s), propTypes, default props for date ranges
* rhsmApiTypes, query check, include beginning, ending params
* viewReducer, move date range to global query
cdcabrera added a commit that referenced this pull request Apr 26, 2021
* productView(s), propTypes, default props for date ranges
* rhsmApiTypes, query check, include beginning, ending params
* viewReducer, move date range to global query
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202104 project phase story New feature, or process work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants