fix(chart): set y domain appropriately #61
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Set the y-domain according the max y value in the input data...
Related Victory issues:
FormidableLabs/victory#883
https://github.com/FormidableLabs/victory-docs/pull/559/files
How to test
Targets a current edge case where all y values are the same causing the issue noted in Victory charts.
Example data which found this edge case:
Coverage and basic unit test check
$ yarn
$ yarn test
Interactive unit test check
$ yarn
$ yarn test:dev
-->
$ yarn test:dev
Example
...
Updates issue/story
Closes #60