Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pageColumns): maintain columns on granularity change #618

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(pageColumns): maintain columns on granularity change

Notes

  • Minor adjustment to maintain widths during granularity (or any dropdown/select change) that causes the loaders to display for inventory. Appears the minimum widths of the inventory were partially being set by content, this makes them consistently 100%

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. navigate towards the OpenShift Container product view and select any dropdown filter (we used granularity) and confirm the loading display maintains width at smaller screen sizes (< 560px)

Example

...

Updates issue/story

Relates #617 #615

@codecov-io
Copy link

Codecov Report

Merging #618 (0548b54) into ci (21388b3) will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##               ci     #618      +/-   ##
==========================================
- Coverage   93.98%   93.83%   -0.15%     
==========================================
  Files          86       86              
  Lines        2146     2597     +451     
  Branches      548      907     +359     
==========================================
+ Hits         2017     2437     +420     
- Misses        106      137      +31     
  Partials       23       23              
Impacted Files Coverage Δ
src/components/router/redirect.js 65.00% <0.00%> (-5.59%) ⬇️
...nents/productView/productViewOpenShiftDedicated.js 94.44% <0.00%> (-5.56%) ⬇️
...nents/productView/productViewOpenShiftContainer.js 73.75% <0.00%> (-4.69%) ⬇️
src/redux/selectors/subscriptionsListSelectors.js 96.96% <0.00%> (-3.04%) ⬇️
src/redux/selectors/inventoryListSelectors.js 97.29% <0.00%> (-2.71%) ⬇️
src/services/platformServices.js 97.67% <0.00%> (-2.33%) ⬇️
src/redux/selectors/graphCardSelectors.js 98.03% <0.00%> (-1.97%) ⬇️
...s/inventorySubscriptions/inventorySubscriptions.js 89.55% <0.00%> (-1.76%) ⬇️
src/components/inventoryList/inventoryList.js 90.54% <0.00%> (-1.46%) ⬇️
src/components/graphCard/graphCardHelpers.js 98.61% <0.00%> (-1.39%) ⬇️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21388b3...0548b54. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202104 project phase bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants