Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(router): ent-4208 activate routeDetail context #813

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

cdcabrera
Copy link
Member

What's included

  • refactor(router): ent-4208 activate routeDetail context
    • config, product configs add product label
    • config, routes productId for rhel archs
    • router, hook, add routeDetail context provider
    • hooks, passthrough for useRouteDetail
    • productViews, apply useRouteDetail hook

Notes

  • State management for product configuration, base work for RHOSAK, ent-4366

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. navigate between products, confirm existing behavior remains unchanged. there should be no visual or behavioral differences

Example

...

Updates issue/story

ent-4208
relates ent-4366

@cdcabrera cdcabrera added story New feature, or process work 202112 project phase labels Oct 11, 2021
@cdcabrera cdcabrera force-pushed the ent-4208-context-router branch from 8b11b09 to c6aee18 Compare October 11, 2021 14:51
@codecov-commenter
Copy link

Codecov Report

Merging #813 (b5e1f66) into ci (7d0b416) will decrease coverage by 0.47%.
The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##               ci     #813      +/-   ##
==========================================
- Coverage   95.39%   94.91%   -0.48%     
==========================================
  Files         101      101              
  Lines        2843     2854      +11     
  Branches     1036     1038       +2     
==========================================
- Hits         2712     2709       -3     
- Misses        123      135      +12     
- Partials        8       10       +2     
Impacted Files Coverage Δ
src/config/routes.js 100.00% <ø> (ø)
src/hooks/useRouter.js 100.00% <ø> (ø)
src/components/router/routerHelpers.js 98.68% <75.00%> (-1.32%) ⬇️
src/components/productView/productView.js 100.00% <100.00%> (ø)
...nents/productView/productViewOpenShiftContainer.js 84.09% <100.00%> (ø)
...nents/productView/productViewOpenShiftDedicated.js 100.00% <100.00%> (ø)
src/components/router/router.js 96.55% <100.00%> (+0.12%) ⬆️
src/components/router/routerContext.js 100.00% <100.00%> (ø)
src/config/product.openshiftDedicated.js 95.45% <100.00%> (+0.21%) ⬆️
src/config/product.rhel.js 87.50% <100.00%> (+0.32%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d0b416...b5e1f66. Read the comment docs.

@cdcabrera cdcabrera force-pushed the ent-4208-context-router branch from b5e1f66 to 9bf272e Compare October 11, 2021 17:59
* config, product configs add product label
* config, routes productId for rhel archs
* router, hook, add routeDetail context provider
* hooks, passthrough for useRouteDetail
* productViews, apply useRouteDetail hook
@cdcabrera cdcabrera force-pushed the ent-4208-context-router branch from 9bf272e to b56e537 Compare October 11, 2021 19:32
@cdcabrera cdcabrera merged commit 5e01c5a into RedHatInsights:ci Oct 11, 2021
cdcabrera added a commit that referenced this pull request Nov 29, 2021
* config, product configs add product label
* config, routes productId for rhel archs
* router, hook, add routeDetail context provider
* hooks, passthrough for useRouteDetail
* productViews, apply useRouteDetail hook
cdcabrera added a commit that referenced this pull request Nov 29, 2021
* config, product configs add product label
* config, routes productId for rhel archs
* router, hook, add routeDetail context provider
* hooks, passthrough for useRouteDetail
* productViews, apply useRouteDetail hook
cdcabrera added a commit that referenced this pull request Nov 30, 2021
* config, product configs add product label
* config, routes productId for rhel archs
* router, hook, add routeDetail context provider
* hooks, passthrough for useRouteDetail
* productViews, apply useRouteDetail hook
cdcabrera added a commit that referenced this pull request Dec 6, 2021
* config, product configs add product label
* config, routes productId for rhel archs
* router, hook, add routeDetail context provider
* hooks, passthrough for useRouteDetail
* productViews, apply useRouteDetail hook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202112 project phase story New feature, or process work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants