Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(serviceConfig): ent-4869 empty, null distinction #917

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Apr 5, 2022

What's included

  • fix(serviceConfig): ent-4869 empty, null distinction
    • build, lower global caching to 15 seconds
    • serviceConfig, Array toString masks null, use JSON stringify

Notes

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. observe the graph threshold
  5. select usage = unspecified
  6. observe the graph threshold
  7. clear all filters
  8. observe the graph threshold

You can also follow the original directions noted in ENT-4869
Make a comparison to staging...

Example

...

Updates issue/story

ENT-4869

* build, lower global caching to 15 seconds
* serviceConfig, Array toString masks null, use JSON stringify
@cdcabrera cdcabrera added bug Something isn't working 202204 project phase labels Apr 5, 2022
@cdcabrera cdcabrera merged commit 1af54fe into RedHatInsights:ci Apr 5, 2022
cdcabrera added a commit that referenced this pull request Apr 14, 2022
* build, lower global caching to 15 seconds
* serviceConfig, Array toString masks null, use JSON stringify
@cdcabrera cdcabrera mentioned this pull request Apr 14, 2022
cdcabrera added a commit that referenced this pull request Apr 19, 2022
* build, lower global caching to 15 seconds
* serviceConfig, Array toString masks null, use JSON stringify
cdcabrera added a commit that referenced this pull request Jun 14, 2022
* build, lower global caching to 15 seconds
* serviceConfig, Array toString masks null, use JSON stringify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202204 project phase bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant