Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rhosak): ent-4689 none, unknown billing provider #936

Merged
merged 2 commits into from
May 24, 2022

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented May 24, 2022

What's included

  • fix(rhosak): ent-4689 none, unknown billing provider
    • config, rhosak, none context for empty provider
    • rhsmConstants, disable unused gcp, azure, oracle

Notes

  • @mirekdlugosz @ntkathole @bclarhk @diegomaranhao
  • Requested that we disable viewing providers in the select dropdown that will not be used initially. The associated locale strings are still available
  • None displays when a billing provider result is empty
  • Unknown displays when a billing provider is outside of the defaults of none, aws, gcp, azure, oracle, rh

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm select options have been narrowed to none, aws, and rh
  5. confirm empty billing provider displays none
  6. confirm an "unknown" provider (a provider NOT in accepted list of none, aws, rh, gcp, azure, oracle) displays as Unknown

Example

Screen Shot 2022-05-24 at 2 25 32 PM

None and unknown providers

Screen Shot 2022-05-24 at 2 27 13 PM
Screen Shot 2022-05-24 at 2 27 31 PM

Updates issue/story

updates ent-4689

* config, rhosak, none context for empty provider
* rhsmConstants, disable unused gcp, azure, oracle
@cdcabrera cdcabrera added the 202208 project phase label May 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2022

Codecov Report

Merging #936 (4d3735c) into ci (7d5a3ea) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               ci     #936      +/-   ##
==========================================
+ Coverage   93.99%   94.02%   +0.02%     
==========================================
  Files         129      129              
  Lines        4015     4016       +1     
  Branches     1568     1569       +1     
==========================================
+ Hits         3774     3776       +2     
+ Misses        223      222       -1     
  Partials       18       18              
Impacted Files Coverage Δ
src/services/rhsm/rhsmConstants.js 100.00% <ø> (ø)
src/config/product.rhosak.js 86.36% <100.00%> (+0.31%) ⬆️
src/common/helpers.js 100.00% <0.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d5a3ea...4d3735c. Read the comment docs.

@cdcabrera cdcabrera merged commit 38dee72 into RedHatInsights:ci May 24, 2022
cdcabrera added a commit that referenced this pull request May 24, 2022
* config, rhosak, none context for empty provider
* rhsmConstants, disable unused gcp, azure, oracle
cdcabrera added a commit that referenced this pull request May 25, 2022
* config, rhosak, none context for empty provider
* rhsmConstants, disable unused gcp, azure, oracle
cdcabrera added a commit that referenced this pull request May 25, 2022
* config, rhosak, none context for empty provider
* rhsmConstants, disable unused gcp, azure, oracle
cdcabrera added a commit that referenced this pull request May 26, 2022
* config, rhosak, none context for empty provider
* rhsmConstants, disable unused gcp, azure, oracle
cdcabrera added a commit that referenced this pull request Jun 14, 2022
* config, rhosak, none context for empty provider
* rhsmConstants, disable unused gcp, azure, oracle
@cdcabrera cdcabrera mentioned this pull request Jun 14, 2022
cdcabrera added a commit that referenced this pull request Jun 24, 2022
* config, rhosak, none context for empty provider
* rhsmConstants, disable unused gcp, azure, oracle
cdcabrera added a commit that referenced this pull request Jul 11, 2022
* config, rhosak, none context for empty provider
* rhsmConstants, disable unused gcp, azure, oracle
cdcabrera added a commit that referenced this pull request Jul 11, 2022
* config, rhosak, none context for empty provider
* rhsmConstants, disable unused gcp, azure, oracle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202208 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants