-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rhosak): ent-4689 none, unknown billing provider #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* config, rhosak, none context for empty provider * rhsmConstants, disable unused gcp, azure, oracle
Codecov Report
@@ Coverage Diff @@
## ci #936 +/- ##
==========================================
+ Coverage 93.99% 94.02% +0.02%
==========================================
Files 129 129
Lines 4015 4016 +1
Branches 1568 1569 +1
==========================================
+ Hits 3774 3776 +2
+ Misses 223 222 -1
Partials 18 18
Continue to review full report at Codecov.
|
cdcabrera
added a commit
that referenced
this pull request
May 24, 2022
* config, rhosak, none context for empty provider * rhsmConstants, disable unused gcp, azure, oracle
cdcabrera
added a commit
that referenced
this pull request
May 25, 2022
* config, rhosak, none context for empty provider * rhsmConstants, disable unused gcp, azure, oracle
cdcabrera
added a commit
that referenced
this pull request
May 25, 2022
* config, rhosak, none context for empty provider * rhsmConstants, disable unused gcp, azure, oracle
cdcabrera
added a commit
that referenced
this pull request
May 26, 2022
* config, rhosak, none context for empty provider * rhsmConstants, disable unused gcp, azure, oracle
cdcabrera
added a commit
that referenced
this pull request
Jun 14, 2022
* config, rhosak, none context for empty provider * rhsmConstants, disable unused gcp, azure, oracle
Merged
This was referenced Jun 21, 2022
cdcabrera
added a commit
that referenced
this pull request
Jun 24, 2022
* config, rhosak, none context for empty provider * rhsmConstants, disable unused gcp, azure, oracle
cdcabrera
added a commit
that referenced
this pull request
Jul 11, 2022
* config, rhosak, none context for empty provider * rhsmConstants, disable unused gcp, azure, oracle
cdcabrera
added a commit
that referenced
this pull request
Jul 11, 2022
* config, rhosak, none context for empty provider * rhsmConstants, disable unused gcp, azure, oracle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
None
displays when a billing provider result is emptyUnknown
displays when a billing provider is outside of the defaults ofnone
,aws
,gcp
,azure
,oracle
,rh
How to test
Proxy run check
$ yarn
$ yarn start:proxy
none
,aws
, andrh
none
none
,aws
,rh
,gcp
,azure
,oracle
) displays asUnknown
Example
None and unknown providers
Updates issue/story
updates ent-4689