Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rhosak): ent-4982 activate sort, storage GiB months #945

Merged
merged 1 commit into from
Jun 13, 2022
Merged

fix(rhosak): ent-4982 activate sort, storage GiB months #945

merged 1 commit into from
Jun 13, 2022

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Jun 13, 2022 •
edited
Loading

What's included

  • fix(rhosak): ent-4982 activate sort, storage GiB months

Notes

  • activates the sort for storage GiB months inventory column

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests pass

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm the "streams"/RHOSAK column for storage can now be sorted with the column header button

Example

Screen Shot 2022-06-13 at 12 08 05 PM

Updates issue/story

ent-4982
related ent-5089

@cdcabrera cdcabrera added the 202208 project phase label Jun 13, 2022
@cdcabrera cdcabrera merged commit a7576d1 into RedHatInsights:ci Jun 13, 2022
cdcabrera added a commit that referenced this pull request Jun 14, 2022
@cdcabrera
fix(rhosak): ent-4982 activate sort, storage GiB months (#945)
3ef53f5
@cdcabrera cdcabrera mentioned this pull request Jun 14, 2022
Merged
cdcabrera added a commit that referenced this pull request Jun 14, 2022
@cdcabrera
fix(rhosak): ent-4982 activate sort, storage GiB months (#945)
078f91a
@cdcabrera cdcabrera mentioned this pull request Jun 14, 2022
Merged
cdcabrera added a commit that referenced this pull request Jun 24, 2022
@cdcabrera
fix(rhosak): ent-4982 activate sort, storage GiB months (#945)
7964fa3
@cdcabrera cdcabrera mentioned this pull request Jun 24, 2022
Merged
cdcabrera added a commit that referenced this pull request Jul 11, 2022
@cdcabrera
fix(rhosak): ent-4982 activate sort, storage GiB months (#945)
f4887e8
cdcabrera added a commit that referenced this pull request Jul 11, 2022
@cdcabrera
fix(rhosak): ent-4982 activate sort, storage GiB months (#945)
59c2c1d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
202208 project phase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cdcabrera