wip: fixing all image checks and ListingImage #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuliaghisini
previously requested changes
Jan 27, 2025
src/components/ItaliaTheme/Blocks/Listing/CardWithImage/CardWithImageDefault.jsx
Outdated
Show resolved
Hide resolved
pnicolli
requested changes
Feb 4, 2025
pnicolli
approved these changes
Feb 6, 2025
pnicolli
added a commit
that referenced
this pull request
Feb 6, 2025
* wip: fixing all image checks and ListingImage * fix: removed all code breaking react rules and refactor * fix: review fixes --------- Co-authored-by: Piero Nicolli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix di tutti i check image truthish, in quanto image e' un istanza di un React Element e non puo' essere mai falsish, non rappresenta il possibile ritorno del componente mai.
Da finire di testare per bene, ho iniziato qui https://v3.io-comune.redturtle.it/test-martina/test-fix-img-null-check-bug
PS: Alcune occorrenze simili esistono anche in Volto tipo PreviewImage, se li usiamo e' da scoprire, non ci sono arrivata ancora