-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a lock file for redoc-cli #1169
Comments
The original issue mobxjs/mobx-react#831 was fixed in a new release 6.1.7. The redoc-cli is working again. |
Changed issue name so this can be a request for a lock file :) |
The lock file is not used when you install some dependency from npm, only when your run So, I can't do this. The only idea is to pinpoint a specific version of |
Redoc-cli isn't a dependency though, it's an application itself, which needs to be consistent in its operation. When you tag a release on npm does npm lock the dependency versions? Doesn't seem like it, which is why the tool broke when someone broke the dependency. Maybe I'm missing something? |
This would be very helpful -- currently running into #1442 |
No. When you install a redoc-cli using Shrinkwrap is used if only you clone this repo, go to the |
Oh, sorry. I was wrong. I just investigated it and looks that shrinkwrap is actually used for locking when installing from npm. |
Just a FYI when people start trying to submit bugs about this, mobx-react shipped a funky build which is causing broken-ness (at least when using redoc-cli bundle)
mobxjs/mobx-react#831
Currently breaks with an error like:
Cannot find module '..../.npm/_npx/1868/lib/node_modules/redoc-cli/node_modules/mobx-react/dist/mobxreact.js
(added for searchability)Can redoc-cli ship with a lock file so this kind of thing doesn't happen?
The text was updated successfully, but these errors were encountered: