feat: add optional BASE_PATH to Docker config #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andriyl
force-pushed
the
master
branch
2 times, most recently
from
cc0c845 to
3c4ece9
Compare
|
I have the same problem and this PR would solve it. I think that the changes look good, but it's not up to me 😅 |
RomanHotsiy
approved these changes
Mar 24, 2022
draoncc
requested review from
AlexVarchuk and
zalesky
and removed request for
a team
zalesky
approved these changes
Apr 19, 2022
|
We'll release the new version of docker next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working with redoc I came accross the lack of a "base path" option in the provided Docker image.
My use case is that I have redoc running behind a reverse proxy routing via path matching. E.g. the reverse proxy receives a request to
<host>/docs, strips the request URL of/docsand forwards it to redoc. The way index.tpl.html is constructed, it tries to load favicon.png from<host>/favicon.png. The workaround is to send requests to<host>/docs/instead, where it'll be correctly loaded from<host>/docs/favicon.png, but this feels dirty.Setting
BASE_PATHto/docs/will prepend favicon.png, making it load from<host>/docs/favicon.pngno matter the original request.A possible alternative to this could be allowing users to specify BUNDLE_URL or similar, which defaults to
redoc.standalone.js. That way, users could set BUNDLE_URL to/docs/redoc.standalone.jsand PAGE_FAVICON to/docs/favicon.png. Another possible alternative could be to modify the nginx config.I'd be happy to make adjustments.