Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: large text in examples value #1974

Merged
merged 2 commits into from
May 3, 2022

Conversation

anastasiia-developer
Copy link
Contributor

What/Why/How?

Reference

close #1958

Testing

Screenshots (optional)

Screenshot 2022-04-28 at 18 47 41
Screenshot 2022-04-28 at 18 50 36

Check yourself

  • Code is linted
  • Tested
  • All new/updated code is covered with tests

@anastasiia-developer anastasiia-developer requested a review from a team as a code owner April 28, 2022 15:55
@anastasiia-developer anastasiia-developer requested review from AlexVarchuk and zalesky and removed request for a team April 28, 2022 15:55
@anastasiia-developer anastasiia-developer self-assigned this Apr 28, 2022
@@ -31,6 +31,5 @@ export function Examples({ field }: { field: FieldModel }) {

const ExamplesList = styled.ul`
margin-top: 1em;
padding-left: 0;
list-style-position: inside;
padding-left: 17px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to use here something other than 17px;? Like something from the theme or doesn't use at all

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can use list-style-position: outside; instead of padding-left: 17px;
and it will look like this
Screenshot 2022-04-29 at 11 16 12

@anastasiia-developer anastasiia-developer merged commit 60bc603 into master May 3, 2022
@anastasiia-developer anastasiia-developer deleted the fix/large_text_in_examples_value branch May 3, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Horizontal scrollbar for path and query parameters
3 participants