You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I wanted to report a small bug I found when going a bit deeper into the code.
In trainer.py there is a function for computing the unit norm of the training data. This is the function:
def compute_unit_norms(X):
norms = np.zeros(X[0].shape[1])
for Xi in X:
for i, ind in enumerate(Xi.indices):
norms[ind] = Xi.data[i] ** 2
norms = norms ** .5
norms[np.where(norms == 0)] = 1.0
return norms.astype('float32')
My question here is the following: aren't you missing a += instead of a =inside the for loop?. The forth line of the code then would be
norms[ind] += Xi.data[i] ** 2
And thank you guys for sharing the library :)
The text was updated successfully, but these errors were encountered:
I wanted to report a small bug I found when going a bit deeper into the code.
In
trainer.py
there is a function for computing the unit norm of the training data. This is the function:My question here is the following: aren't you missing a
+=
instead of a=
inside the for loop?. The forth line of the code then would beAnd thank you guys for sharing the library :)
The text was updated successfully, but these errors were encountered: