Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Choose Chromium version to install #22

Open
benperiton opened this issue May 3, 2018 · 3 comments
Open

Feat: Choose Chromium version to install #22

benperiton opened this issue May 3, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@benperiton
Copy link
Member

Would it be possible to set the Chromium version used with Puppeteer via this package?
It seems that although Puppeteer provide a way to set the Chromium version during install, they don't want to use ENV vars in the actual code (puppeteer/puppeteer#2491 (comment)), so it needs to be set when creating the browser.

e.g.

const browserFetcher = puppeteer.createBrowserFetcher();
const revision = browserFetcher.revisionInfo(process.env.PUPPETEER_CHROMIUM_REVISION);
const browser = await puppeteer.launch({executablePath: revisionInfo.executablePath})

This would provide a way to pin Chromium to a version that works for individual needs - #17 for instance - and could help in the future for any breaking changes in Chromium.

@DanielRuf DanielRuf added the enhancement New feature or request label May 8, 2018
@benperiton
Copy link
Member Author

This would also be good for #47 - puppeteer also accepts a env to not download Chromium.
I'll try and find time next week to update the pull request with a better way to use other versions if needed for advanced use.

@DanielRuf
Copy link
Contributor

cross-env or something similar can be probably used.

@thedewpoint
Copy link

@DanielRuf @benperiton
Similar issue, trying to override the executable path for chromium. At work we are behind a firewall and already have an executable, so would like to provide the path instead of downloading chromium. Puppeteers api allows for this, is there any way to pass those configurations to relaxedjs?

https://github.com/GoogleChrome/puppeteer/blob/master/docs/api.md#puppeteerexecutablepath

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants