-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong error issued with OpenID Connect security schema #485
Comments
Any developer could comment this issue ? |
@cvgaviao , sorry for the delay. I have opened an issue here to get some clarification on the spec: These other open issues suggest that OpenAPI may still be trying to figure out how to model the complex relationship between OIDC and OAuth, and the meaning of the scopes array in Security Requirements Object:
Maybe we'll see some refinements to this in future versions of the OpenAPI spec. In the meantime, I think the safe thing to do is to limit the validation to apply only to security requirements for oauth2-typed security schemes. We will try to get this fix into the next patch release. |
@tedepstein, I'm wondering here... don't you think? |
@cvgaviao , we would need to look more carefully at this. If this is required of all OID implementations, then it's possible to implement validation and/or code assist for OID scopes/roles. For validation purposes, we generally don't rely on things outside of the OpenAPI document or the OpenAPI specification, unless it's directly referenced from the document as a If you think validation and/or code assist for OID scopes would be valuable, could you please open a separate issue for it? I'd like to limit the scope of this issue to fixing the error condition. |
@tedepstein, for me actually just not throw an error when not providing a scope its ok for now. But as I'm moving my application to OID, I investigated many OpenID Connect standard providers and all of then uses the for example, take a look on the path provided by MS Azzure: https://login.windows.net/common/.well-known/openid-configuration and for google: https://accounts.google.com/.well-known/openid-configuration |
Thanks for that info, @cvgaviao . |
An OpenID Connect schema does require only two fields:
Then in a Path we need to refer to a security schema using
security
tag:But editor is wrongly issuing an error as the schema were oAuth2:
"admin" does not match any scope name defined in the OpenIdC security scheme.
The text was updated successfully, but these errors were encountered: