Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prettier table CSS #47

Closed
sid-kap opened this issue Jan 29, 2020 · 4 comments
Closed

Prettier table CSS #47

sid-kap opened this issue Jan 29, 2020 · 4 comments

Comments

@sid-kap
Copy link

sid-kap commented Jan 29, 2020 •
edited
Loading

Jupyter has pretty nice default CSS for tables, for example when printed by Pandas. Would we be able to copy some of this CSS to make rendered tables look nicer?
https://github.com/jupyter/notebook/blob/master/notebook/static/notebook/less/renderedhtml.less

There are some nice example table screenshots in jupyter/notebook#1776
@amit1rrr
Copy link
Member

amit1rrr commented Jan 29, 2020 •
edited
Loading

@sid-kap Thanks for reporting and linking to the css. I have picked up the changes and deployed it. Tables look much nicer now. Checkout screenshot below :)

You would get this with next month's update for Affirm along with markdown commenting & collapsible diffs.

Cheers!

Screenshot 2020-01-29 at 8 08 44 PM

@amit1rrr
Copy link
Member

Reopening for a bit - turns out the negative lookahead I used in the regex is not supported in Firefox & Safari yet. So I had to revert the change. Will deploy a fix in some time.

@amit1rrr amit1rrr reopened this Jan 29, 2020
@amit1rrr
Copy link
Member

Fixed, resolving!

@sid-kap
Copy link
Author

sid-kap commented Jan 31, 2020

Awesome, thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amit1rrr @sid-kap