Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect code generated involving comments and ASI #36

Closed
Conduitry opened this issue Mar 24, 2020 · 1 comment · Fixed by #67 or sveltejs/svelte#6889
Closed

Incorrect code generated involving comments and ASI #36

Conduitry opened this issue Mar 24, 2020 · 1 comment · Fixed by #67 or sveltejs/svelte#6889
Labels
bug Something isn't working

Comments

@Conduitry
Copy link
Collaborator 

cr.print(cr.b`return (\n// comment\nfoo)`).code

evaluates to

'return // comment\nfoo;'

which is incorrect due to ASI. This seems to be handled correctly without the comment.
@Conduitry
Copy link
Collaborator Author

It looks like this is also present for /* comment */ as well.

@Conduitry Conduitry added the bug Something isn't working label May 9, 2020
@Conduitry Conduitry mentioned this issue Sep 3, 2020
Closed
@tanhauhau tanhauhau mentioned this issue Nov 1, 2021
Merged
@Conduitry Conduitry mentioned this issue Nov 1, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@Conduitry