Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TypeScript 5.3 #66

Closed
benmccann opened this issue Dec 2, 2023 · 2 comments · Fixed by #67
Closed

Support TypeScript 5.3 #66

benmccann opened this issue Dec 2, 2023 · 2 comments · Fixed by #67

Comments

@benmccann
Copy link
Contributor

From the SvelteKit version-2 branch:

packages/kit
└─┬ dts-buddy 0.4.0
  └── ✕ unmet peer typescript@">=5.0.4 <5.3": found 5.3.2
@dominikg
Copy link
Collaborator

dominikg commented Dec 2, 2023

ts 5.3 doesn't parse jsdoc completely anymore by default, we might have to set a new option here https://github.com/Rich-Harris/dts-buddy/blob/main/src/index.js#L79 see microsoft/TypeScript#55739

@benmccann
Copy link
Contributor Author

benmccann commented Dec 2, 2023

Ah. We also have some issues generating the types for the docs (microsoft/TypeScript#49273 (comment)). Perhaps the more expedient solution is to downgrade to an earlier 5.x release since that would kill two birds with one stone.

The site will need to stay on a 5.0.x release. We could upgrade Kit itself to the latest if we can fix this though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants