Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of .shepherd-transparent-text class #238

Closed
BrianSipple opened this issue Sep 9, 2018 · 4 comments
Closed

Remove usage of .shepherd-transparent-text class #238

BrianSipple opened this issue Sep 9, 2018 · 4 comments

Comments

@BrianSipple
Copy link
Contributor

BrianSipple commented Sep 9, 2018

The shepherd-transparent-text CSS class is used pretty liberally throughout the test dummy app, and it's even used as a default class for the "error" step we add in the tour service.

However, I don't think this class is actually a part of the styles for shepherd, and we don't have any style rules for it here. It seems to be limited to shepherd's test dummy app styling.

If that's the case, I think we should get rid of it here to eliminate some confusion.

@BrianSipple
Copy link
Contributor Author

I think this also applies to the .shepherd class -- in both ember-shepherd and shepherd.

@RobbieTheWagner
Copy link
Owner

@BrianSipple are you saying just remove unused classes from demos? The demos use some custom classes, to show that you can pass classes in and such.

@BrianSipple
Copy link
Contributor Author

BrianSipple commented Sep 10, 2018

I'm not opposed to having dummy class names when we're demoing such usage. That said...

@RobbieTheWagner
Copy link
Owner

Totally agree with that. Those classes are all arbitrary. Having a class of shepherd-open doesn't guarantee the step is open either. We can probably remove all those classes except shepherd-theme-arrows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants