Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ros-humble-ament-cmake 1.3.2 not compatible with cmake > 3.24 #13

Closed
danzimmerman opened this issue Sep 1, 2022 · 2 comments
Closed

Comments

@danzimmerman
Copy link

danzimmerman commented Sep 1, 2022

Issue

Fresh installs on Linux are pulling in cmake 3.24.1 from conda-forge which seems to be triggering the issue described in

ament/ament_cmake#396

and fixed in

ament/ament_cmake#395

Symptom

Building certain packages can result in workspace build failures with errors like

--- stderr: ur_controllers
CMake Error at /home/<user>/ros/humble_ws/install/share/ur_dashboard_msgs/cmake/ament_cmake_export_targets-extras.cmake:18 (message):
  Failed to find exported target names in
  '/home/<user>/ros/humble_ws/install/share/ur_dashboard_msgs/cmake/export_ur_dashboard_msgs__rosidl_generator_cExport.cmake'
Call Stack (most recent call first):
  /home/<user>/ros/humble_ws/install/share/ur_dashboard_msgs/cmake/ur_dashboard_msgsConfig.cmake:41 (include)
  CMakeLists.txt:19 (find_package)


---

Possible Resolutions

Seems like there's a 1.5.0 release, but it's still too old to pull this in and it would still need a patch.

I think it's possible that this is enough:

https://patch-diff.githubusercontent.com/raw/ament/ament_cmake/pull/395.patch

I still don't quite grok how to properly make my own PR for patching packages but if I make enough progress on the tasks I'm unblocking re: this issue I will look into it again.

Downgrading to cmake 3.23.3 is a workaround.

@Tobias-Fischer
Copy link
Contributor

We already have the patch in place: https://github.com/RoboStack/ros-humble/blob/main/patch/ros-humble-ament-cmake-export-targets.patch

But it seems like we need to actually re-build ament-cmake-export-targets.

@Tobias-Fischer
Copy link
Contributor

Fixed with the new builds :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants