You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is the idea that the "original" ids are just pre-normalization, or is this something coming from the source upstream?
If the former, it might make sense to add them during the normalization phase, and that could easily be incorporated into the NormalizationScheme, which would let us easily specify in Graph Specs whether we want them or not.
I worry about altering the kgx file writer for this purpose on a mode based level like that, because for example, someone might use that write_kgx_edge function on post-normalized nodes without realizing it would do that, creating bogus original ids.
We used to have original ids on every edge, and in many cases it can be helpful for quicker troubleshooting etc, but we removed them when we started saving normalization maps for every run.. We could possibly just implement this for every edge again and not worry about a mode or configuration. What do you think @cbizon ?
MonarchKG has the following properties recorded on each association they record.
This should be fairly trivial with changing the following lines:
https://github.com/RobokopU24/ORION/blob/8d8b643284e70e23c6bb5e2bb48425c9bc949ee4/Common/loader_interface.py#L28-31
becomes:
and
https://github.com/RobokopU24/ORION/blob/8d8b643284e70e23c6bb5e2bb48425c9bc949ee4/Common/kgx_file_writer.py#L138-144
becomes:
The text was updated successfully, but these errors were encountered: