Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove any added fields from message before saving #71

Open
maximusunc opened this issue Oct 29, 2020 · 3 comments
Open

Remove any added fields from message before saving #71

maximusunc opened this issue Oct 29, 2020 · 3 comments

Comments

@maximusunc
Copy link
Collaborator

We are creating an 'id' property in all the results for display purposes, but this field shouldn't be saved externally from Robokop. I downloaded an answer object and it had ids in the results.

@maximusunc maximusunc added the bug label Oct 29, 2020
@alongreyber
Copy link
Contributor

Haven't been able to reproduce this. Can you give some more details?

@maximusunc
Copy link
Collaborator Author

http://robokop.renci.org:7080/question/RrJkvdM3/answer/8DJnjJB5

Download the answer json, and you'll see an ID with each result that is just its index.

@maximusunc
Copy link
Collaborator Author

I would like to expand the scope of this issue and make sure we remove every extra field that we add in to the message before we save it. This includes:

  • id field in the results
  • empty curie list in query graph
  • label in query graph

@maximusunc maximusunc changed the title ID is being saved in messages Remove any added fields from message before saving Dec 19, 2020
@maximusunc maximusunc added Type: Bug and removed bug labels Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants