Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

class_: Register reclaim_from_cpp with constructing type #33

Merged
merged 2 commits into from
Apr 14, 2020
Merged

class_: Register reclaim_from_cpp with constructing type #33

merged 2 commits into from
Apr 14, 2020

Conversation

EricCousineau-TRI
Copy link
Collaborator

@EricCousineau-TRI EricCousineau-TRI commented Nov 19, 2019 •
edited
Loading

@EricCousineau-TRI
Copy link
Collaborator Author

This came about because I was trying to bind Simulator::release_context(), but would get the following error:

Instance is registered but does not have a registered reclaim method. Internal error?

@EricCousineau-TRI EricCousineau-TRI mentioned this pull request Nov 19, 2019
Merged
@EricCousineau-TRI EricCousineau-TRI mentioned this pull request Apr 14, 2020
Closed
@EricCousineau-TRI EricCousineau-TRI force-pushed the feature-2019-11-18-context branch 7 times, most recently from 87dd63a to ced13e9 Compare April 14, 2020 19:04
@EricCousineau-TRI
Copy link
Collaborator Author

FTR, debugging in a prior push was helpful for me. I will try to upstream some utilities / suggestions.
Specifically, commit 09a1b0c (focus CI) and 87dd63a (drilling in to debug).

@EricCousineau-TRI EricCousineau-TRI force-pushed the feature-2019-11-18-context branch from ced13e9 to 769e8c0 Compare April 14, 2020 19:16
@EricCousineau-TRI EricCousineau-TRI mentioned this pull request Apr 14, 2020
Open
@EricCousineau-TRI EricCousineau-TRI force-pushed the feature-2019-11-18-context branch from 769e8c0 to f07db0a Compare April 14, 2020 19:25
@EricCousineau-TRI EricCousineau-TRI force-pushed the feature-2019-11-18-context branch from f07db0a to 2db3dfc Compare April 14, 2020 19:27
EricCousineau-TRI
EricCousineau-TRI commented Apr 14, 2020
View reviewed changes
Copy link
Collaborator Author

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@sammy-tri for review, please?

Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @sammy-tri)

sammy-tri
sammy-tri approved these changes Apr 14, 2020
View reviewed changes
Copy link

@sammy-tri sammy-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I understand at a surface level what's going on from the test and the linked PR, but I'm not going to claim I understand what's going on in the pybind11 internals. If it solves your problem, :lgtm:.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@EricCousineau-TRI
Copy link
Collaborator Author

Thanks!

@EricCousineau-TRI EricCousineau-TRI merged commit cb82d59 into RobotLocomotion:drake Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sammy-tri sammy-tri sammy-tri approved these changes

Assignees

@sammy-tri sammy-tri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EricCousineau-TRI @sammy-tri