Add support for python 3.12 #54
Conversation
- Replace `assertEquals` (deprecated) with `assertEqual`. - Replace `self.assert_` with `self.assertTrue`. - Fix docstrings in `cpplint.py` that contain invalid escape sequences to be raw strings.
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers (waiting on @svenevs)
cpplint/cpplint.py line 1115 at r1 (raw file):
def RepositoryName(self): r"""FullName after removing the local path to the repository.
FYI this gets done because otherwise cpplint's internal tests fail talking about invalid escape sequences. The other solution is to turn \. into \\. and \D into \\D. doesn't seem to really matter...
cpplint/cpplint_unittest.py line 128 at r1 (raw file):
# Perform lint on single line of input and return the error message. def PerformSingleLineLint(self, code): error_collector = ErrorCollector(self.assertTrue)
working, we need this job from RobotLocomotion/drake#21013 to pass in order to confirm.
There is one expected failure, unrelated to the changes here, compare to the previous launch
[2:23:39 PM] //tools/jupyter:py/jupyter_notebook_test FAILED in 0.3s
[2:23:39 PM] /Users/admin/workspace/mac-arm-ventura-unprovisioned-clang-bazel-experimental-release/_bazel_admin/4c3a1e08493e1ec72f883b9e38f87cf5/execroot/drake/bazel-out/darwin_arm64-opt/testlogs/tools/jupyter/py/jupyter_notebook_test/test.log
[2:23:39 PM] //tools/workspace/styleguide:cpplint_unittest FAILED in 1.1s
[2:23:39 PM] /Users/admin/workspace/mac-arm-ventura-unprovisioned-clang-bazel-experimental-release/_bazel_admin/4c3a1e08493e1ec72f883b9e38f87cf5/execroot/drake/bazel-out/darwin_arm64-opt/testlogs/tools/workspace/styleguide/cpplint_unittest/test.log
If //tools/workspace/styleguide:cpplint_unittest works correctly then we are good to merge this.
There was a problem hiding this comment.
If the 3.12 smoke test build passes, then we should land this and bump Drake to use it (separately from the 3.12 upgrade PR).
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee jwnimmer-tri(platform), needs at least two assigned reviewers (waiting on @svenevs)
|
|
There was a problem hiding this comment.
Reviewable status: needs at least two assigned reviewers (waiting on @svenevs)
cpplint/cpplint_unittest.py line 128 at r1 (raw file):
Previously, svenevs (Stephen McDowell) wrote…
working, we need this job from RobotLocomotion/drake#21013 to pass in order to confirm.
There is one expected failure, unrelated to the changes here, compare to the previous launch
[2:23:39 PM] //tools/jupyter:py/jupyter_notebook_test FAILED in 0.3s [2:23:39 PM] /Users/admin/workspace/mac-arm-ventura-unprovisioned-clang-bazel-experimental-release/_bazel_admin/4c3a1e08493e1ec72f883b9e38f87cf5/execroot/drake/bazel-out/darwin_arm64-opt/testlogs/tools/jupyter/py/jupyter_notebook_test/test.log [2:23:39 PM] //tools/workspace/styleguide:cpplint_unittest FAILED in 1.1s [2:23:39 PM] /Users/admin/workspace/mac-arm-ventura-unprovisioned-clang-bazel-experimental-release/_bazel_admin/4c3a1e08493e1ec72f883b9e38f87cf5/execroot/drake/bazel-out/darwin_arm64-opt/testlogs/tools/workspace/styleguide/cpplint_unittest/test.logIf
//tools/workspace/styleguide:cpplint_unittestworks correctly then we are good to merge this.
done
[3:55:50 PM] //tools/workspace/styleguide:cpplint_unittest PASSED in 1.4s
|
Looks like we need either a platform stamp or a forceful hand 😉 |
assertEquals(deprecated) withassertEqual.self.assert_withself.assertTrue.cpplint.pythat contain invalid escape sequences to be raw strings.This change is