Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LifecycleNode support in rclnodejs #589

Closed
mattrichard opened this issue Mar 1, 2020 · 3 comments · Fixed by #722
Closed

LifecycleNode support in rclnodejs #589

mattrichard opened this issue Mar 1, 2020 · 3 comments · Fixed by #722
Assignees
@wayneparrott
Labels
feature

Comments

@mattrichard
Copy link
Collaborator

rclnodejs should support lifecycle (a.k.a managed) nodes.

https://github.com/ros2/demos/blob/master/lifecycle/README.rst
@minggangw minggangw mentioned this issue Mar 1, 2020
Open
18 tasks
@wayneparrott wayneparrott self-assigned this Nov 5, 2020
@wayneparrott
Copy link
Collaborator

I reviewed the lifecycle design and the rcl and rclcpp implementations. Implementing a rclnodejs lifecycle node using the rcl lifecycle api looks straight forward. I have an early working version which I need to write tests. Hoping to commit a PR next week for this feature.

@minggangw
Copy link
Member

Excited to know that, we are closing the gap!

@wayneparrott wayneparrott mentioned this issue Nov 13, 2020
Merged
@minggangw
Copy link
Member

Thanks for @wayneparrott's contributions, we are one step closer to the full-feature client 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wayneparrott wayneparrott

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lifecycle api, types, tests & example
3 participants
@mattrichard @wayneparrott @minggangw