fix(message-parser): User mention with @ character (#894)

* Fix user mention with email pattern and add tests * adding languages support to mention and channel parser Co-authored-by: gabriellsh <[email protected]>
RocketChat · Nov 10, 2022 · aa9bc06 · aa9bc06
1 parent 25419be
commit aa9bc06
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 3 deletions.
diff --git a/packages/message-parser/src/grammar.pegjs b/packages/message-parser/src/grammar.pegjs
@@ -177,15 +177,20 @@ anyText
   / [\x61-\x7A] // a b c d e f g h i j k l m n o p q r s t u v w x y z
   / nonascii
 
-utf8_names_validation = $[0-9a-zA-Z-_.]+
+utf8_names_validation = $([-_.] / alphaChar / decimalNumberChar)+
 
-matrix_server_validation = ":" utf8_names_validation
+username_matrix_server_validation = ":" utf8_names_validation
+
+username_email_validation = "@" utf8_names_validation
 
 UserMention
   = t:Text "@"+ user:utf8_names_validation {
       return reducePlainTexts([t, plain('@' + user)])[0];
     }
-  / "@"+ user:$(utf8_names_validation matrix_server_validation) {
+  / "@"+ user:$(utf8_names_validation username_matrix_server_validation) {
+      return mentionUser(user);
+    }
+  / "@"+ user:$(utf8_names_validation username_email_validation) {
       return mentionUser(user);
     }
   / "@"+ user:utf8_names_validation { return mentionUser(user); }

diff --git a/packages/message-parser/tests/mention.test.ts b/packages/message-parser/tests/mention.test.ts
@@ -13,6 +13,22 @@ test.each([
     '@marcos.defendi:matrix.org',
     [paragraph([mentionUser('marcos.defendi:matrix.org')])],
   ],
+  ['@[email protected]', [paragraph([mentionUser('[email protected]')])]],
+  [
+    '@[email protected]',
+    [paragraph([mentionUser('[email protected]')])],
+  ],
+  ['@téstãçâò', [paragraph([mentionUser('téstãçâò')])]],
+  ['@สมชาย', [paragraph([mentionUser('สมชาย')])]],
+  ['@李祖阳', [paragraph([mentionUser('李祖阳')])]],
+  ['@あおい', [paragraph([mentionUser('あおい')])]],
+  ['@アオイ', [paragraph([mentionUser('アオイ')])]],
+  ['@Владимир', [paragraph([mentionUser('Владимир')])]],
+  ['@Кириллица', [paragraph([mentionUser('Кириллица')])]],
+  [
+    'test @Кириллица test',
+    [paragraph([plain('test '), mentionUser('Кириллица'), plain(' test')])],
+  ],
 ])('parses %p', (input, output) => {
   expect(parse(input)).toMatchObject(output);
 });