Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps,mp3-encoder): Yarn resolution of lamejs #731

Merged
merged 2 commits into from
May 25, 2022

Conversation

tassoevan
Copy link
Collaborator

Proposed changes (including videos or screenshots)

It avoids relying on Yarn's GitHub plugin because it (1) unexpectedly invokes the building of dependency's source code and (2) may give different checksums for each user.

Issue(s)

Further comments

@tassoevan tassoevan added 🐛 Bug Something isn't working 📦 mp3-encoder labels May 25, 2022
@tassoevan tassoevan requested a review from a team May 25, 2022 20:32
@tassoevan tassoevan changed the title fix(deps): Yarn resolution of lamejs fix(deps,mp3-encoder): Yarn resolution of lamejs May 25, 2022
@tassoevan tassoevan force-pushed the deps/yarn-resolution branch from f5dfe76 to 91d93e9 Compare May 25, 2022 21:11
@tassoevan tassoevan merged commit c6c4e21 into develop May 25, 2022
@tassoevan tassoevan deleted the deps/yarn-resolution branch May 25, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working 📦 mp3-encoder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants