Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fuselage): update optionTitle component styles #790

Merged
merged 10 commits into from
Aug 11, 2022
Merged

fix(fuselage): update optionTitle component styles #790

merged 10 commits into from
Aug 11, 2022

Conversation

guijun13
Copy link
Contributor

@guijun13 guijun13 commented Jul 26, 2022 •
edited
Loading

Proposed changes (including videos or screenshots)

  • Update padding block values of OptionTitle
  • Refactor style files of Option and Options
  • Update padding block value of Dropdown
Location Before After
Sort Dropdown image Screen Shot 2022-08-05 at 15 54 14
User Dropdown image Screen Shot 2022-08-05 at 15 54 05
Create new Dropdown Screen Shot 2022-08-08 at 11 33 17 Screen Shot 2022-08-05 at 15 54 26

Issue(s)

Further comments

@guijun13 guijun13 requested a review from dougfabris July 26, 2022 20:19
@guijun13 guijun13 marked this pull request as ready for review July 26, 2022 20:21
@guijun13 guijun13 mentioned this pull request Jul 26, 2022
Merged
@ivans-netto
Copy link

Looking great @guijun13

@CLAassistant
Copy link

CLAassistant commented Aug 10, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kodiakhq kodiakhq bot merged commit 3a2cbb3 into develop Aug 11, 2022
@kodiakhq kodiakhq bot deleted the fix/option-title branch August 11, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougfabris dougfabris dougfabris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guijun13 @ivans-netto @CLAassistant @dougfabris