Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(message-rewrite): Remove emojis inside links #800

Merged
merged 8 commits into from
Aug 16, 2022
Merged

Conversation

hugocostadev
Copy link
Contributor

@hugocostadev hugocostadev commented Aug 9, 2022

Proposed changes (including videos or screenshots)

https:// renders an emoji in some situations
Example:
image

To fix the issue I changed the logic for grammar domainName

Benchmark compared with develop branch:
image

Issue(s)

Further comments

Copy link
Contributor

@filipemarins filipemarins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is not only about the link, the issue is the emoji is being rendered in the middle of the sentence. Examples:
10:30 will render 1😇0.
he:)llo is rendering he😄llo.
In both scenarios it should not render the emoji.

@ggazzo
Copy link
Member

ggazzo commented Aug 10, 2022

I'm sorry but the url error is a valid one and the change actually solves the issue somehow.

so if the problem is too complex to solve, we can break into smaller fixes, I will let my approval here, fell free to dismiss

ggazzo
ggazzo previously approved these changes Aug 10, 2022
@CLAassistant
Copy link

CLAassistant commented Aug 10, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

filipemarins
filipemarins previously approved these changes Aug 16, 2022
@kodiakhq kodiakhq bot merged commit 670a5f2 into develop Aug 16, 2022
@kodiakhq kodiakhq bot deleted the fix/emoji-in-urls branch August 16, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants