-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(message-rewrite): Remove emojis inside links #800
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is not only about the link, the issue is the emoji is being rendered in the middle of the sentence. Examples:
10:30
will render 1😇0.
he:)llo
is rendering he😄llo.
In both scenarios it should not render the emoji.
I'm sorry but the url error is a valid one and the change actually solves the issue somehow. so if the problem is too complex to solve, we can break into smaller fixes, I will let my approval here, fell free to dismiss |
|
Proposed changes (including videos or screenshots)
https:// renders an emoji in some situations
Example:
To fix the issue I changed the logic for grammar
domainName
Benchmark compared with
develop
branch:Issue(s)
Further comments