Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fuselage): Modal Hero Image #860

Merged
merged 3 commits into from
Oct 4, 2022
Merged

feat(fuselage): Modal Hero Image #860

merged 3 commits into from
Oct 4, 2022

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Sep 30, 2022 •
edited
Loading

Proposed changes (including videos or screenshots)

Screen Shot 2022-10-04 at 10 17 45

Issue(s)

Further comments

gabriellsh
gabriellsh requested changes Oct 3, 2022
View reviewed changes
Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make use of the object-fit property so that images do not stretch as in the provided screenshot.

@dougfabris dougfabris requested a review from gabriellsh October 4, 2022 13:18
@kodiakhq kodiakhq bot merged commit ce85b97 into develop Oct 4, 2022
@kodiakhq kodiakhq bot deleted the feat/modal-hero-image branch October 4, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriellsh gabriellsh gabriellsh approved these changes

Assignees
No one assigned
Labels
📦 fuselage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dougfabris @gabriellsh