Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fuselage): Tag not receiving props properly #865

Merged
merged 4 commits into from
Oct 14, 2022
Merged

fix(fuselage): Tag not receiving props properly #865

merged 4 commits into from
Oct 14, 2022

Conversation

dougfabris
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Further comments

@dougfabris dougfabris requested a review from a team October 11, 2022 14:51
@rique223 rique223 mentioned this pull request Oct 11, 2022
Merged
gabriellsh
gabriellsh requested changes Oct 11, 2022
View reviewed changes
Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct fix for this case would be to fix the type annotation. We shouldn't use Box in this case, because at one point this component was rewritten to remove Box from it's dependencies (probably due to performance).

@dougfabris dougfabris requested a review from gabriellsh October 13, 2022 19:18
@dougfabris dougfabris merged commit 5e5f25d into develop Oct 14, 2022
@dougfabris dougfabris deleted the fix/tag branch October 14, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriellsh gabriellsh gabriellsh approved these changes

Assignees
No one assigned
Labels
📦 fuselage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dougfabris @gabriellsh