Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fuselage): add message names wrapper and update system message #889

Merged
merged 7 commits into from
Nov 4, 2022

Conversation

filipemarins
Copy link
Contributor

@filipemarins filipemarins commented Nov 1, 2022

Proposed changes (including videos or screenshots)

Add MessageNames wrapper to display name and username inline and separate them with a blank space.

Update message system font size:

Before:
Screenshot 2022-11-01 at 16 12 38

After:
Screenshot 2022-11-01 at 16 16 28

Add system variation to ThreadOrigin component
Screenshot 2022-10-31 at 14 05 09

Issue(s)

Further comments

The system variation on ThreadOrigin component will be used to show the message removed status.

@filipemarins filipemarins changed the title feat(fuselage): update message system font size and add variant feat(fuselage): add message names wrapper and update system message Nov 1, 2022
Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only suggestion is to change MessageNames to something more descriptive, since it can be confused with MessageName. Perhaps MessageNameContainer?

gabriellsh
gabriellsh previously approved these changes Nov 3, 2022
@gabriellsh gabriellsh merged commit 97dd401 into develop Nov 4, 2022
@gabriellsh gabriellsh deleted the tc-189 branch November 4, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants