Change to reflect moving to streams in RC-side of development #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replies to commands are temporarily commented
- Better logs - No more using of a global variable to set a dynamic userId to subscribe to the client commands stream, pass it as a parameter instead - SDK will not halt if server does not have client-commands stream
Improve use of logs regarding ClientCommands
Each client has a name and a version Gets version of SDK from package.json
timkinnane
approved these changes
Aug 18, 2018
There was a problem hiding this comment.
@mikaelmello I'm going to approve this now and apply some minor changes on the client commands branch before merging into a release. Might need some assistance if there's conflicts with the other big PR from @JoseRenan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of Client Commands on server-side is moving from a collection and publication to a single stream
A way to reply to the commands is not implemented yet