Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification mail may confuse recipients due to misleading From-Field #17008

Closed
abelbabel opened this issue Mar 25, 2020 · 3 comments
Closed

Comments

@abelbabel
Copy link

Notification mails show names of participants that sent a chat-message while using configured global mail from address. Users may get confused and they may reply to those notification mails, because it appears to them that they got the mail from the participant whose name is part of the From-Header ...

Possible solution: Remove name from From-Header-Field.

Instead of

email.from = `${ String(username).replace(/@/g, '%40').replace(/[<>,]/g, '') } <${ settings.get('From_Email') }>`;

use

email.from = `${ settings.get('From_Email') }`;

@abelbabel
Copy link
Author

abelbabel commented Apr 8, 2020

Any comments from Rocket.Chat-devs on this simple issue? @rodrigok @sampaiodiego @engelgabriel @gabriellsh ...

@sampaiodiego
Copy link
Member

closing as duplicated of #12176

there is also a PR that tries to fix the issue #15767

@abelbabel
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants