[Push Notifications] Again problems sending notifications that have already been read.

[aleadco]

Description:

@sampaiodiego and @diegolmello In previous reports, I do not mention them because I can not find them now hahahaha, we discussed the notifications that are sent to mobile phones and that were already seen from a browser.
Apparently it had been resolved and the behavior held up pretty well from my perception. Now we see the same problems again.

Steps to reproduce:

I detail the problem:
I am working on the PC receiving and sending messages from the browser and the mobile is disconnected from the network. When I reconnect the mobile I get all the push notifications of messages that I had already read.

Expected behavior:

Actual behavior:

Server Setup Information:

• Version of Rocket.Chat Server: 3.12.0
• Operating System: Ubuntu
• Deployment Method: tar
• Number of Running Instances: 1
• DB Replicaset Oplog: wiredTiger (oplog Habilitado)
• NodeJS Version: v12.18.4
• MongoDB Version: 4.0.22

Client Setup Information

• Desktop App or Browser Version:
• Operating System:

Additional context

Relevant logs:

[aleadco]

@diegolmello we talked about it in RocketChat/Rocket.Chat.ReactNative#2563

[ankar84]

@aleadco you can check this PR #17357
I think that PR introduced current push notifications send logic.

[aleadco]

@ankar84 I have read the PR and I understand it perfectly. But there is an error associated with the push when the mobile device is not connected to the network.
Do the following test:
1 - Disconnect your mobile from the internet, turn off the Wi-Fi mobile data network.
2 - Access the web client and generate conversations with several users, expect to receive messages and make sure to read them from the web client, expect to receive between 5 and 10 messages. At this point you should no longer receive mobile push messages.
3 - Reconnect your mobile and you will see how you receive all the push messages that you have already read.

However, when the mobile is connected to the network, that does not happen.