Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link containing an anchor does not get rendered #26815

Closed
mmattel opened this issue Sep 6, 2022 · 8 comments
Closed

Link containing an anchor does not get rendered #26815

mmattel opened this issue Sep 6, 2022 · 8 comments

Comments

@mmattel
Copy link

mmattel commented Sep 6, 2022

Description:

When posting a link in RC, I have made the experience that links containing an anchor do not get rendered compared to links not having anchors, see:

[GDPR](https://doc.owncloud.com/server/next/admin_manual/gdpr.html)

[User GDPR Requests](https://doc.owncloud.com/server/next/admin_manual/configuration/user/user_management.html#user-gdpr-requests)

The first one gets rendered properly while the second one having an anchor does not.
Testing the links in github as comment, both are fine.

Steps to reproduce:

see above

Expected behavior:

Links containing anchors render correctly

Actual behavior:

Links do not get rendered when the URL contains an anchor

Server Setup Information:

Note that the RC server is operated by our admin team, the only info I have is the version

  • Version of Rocket.Chat Server: 5.1.0
  • Operating System:
  • Deployment Method:
  • Number of Running Instances:
  • DB Replicaset Oplog:
  • NodeJS Version:
  • MongoDB Version:

Client Setup Information

  • Desktop App or Browser Version: Opera latest
  • Operating System: W10x64

Additional context

Tested via the RC IOS APP (4.29.0) - same result which looks as it is a RC server issue

Relevant logs:

@xmedeko
Copy link

xmedeko commented Sep 8, 2022

Duplicate to #26661 see the comment #26661#issuecomment-1225605879 (and a few other similar link rendering issues here).

@engelgabriel
Copy link
Member

Duplicate to #26661

@hugocostadev
Copy link
Contributor

Reopening since it's not a duplicate to #26661

This issue is being addressed in this PR: RocketChat/fuselage#855

@lestercoyoyjr
Copy link
Contributor

Hi @mmattel can you add a "/" at the end of the url? That should work. See example:

User GDPR Requests

@hugocostadev
Copy link
Contributor

It was already fixed and there is already a Release Candidate. Soon we will be released the official Release.

@mmattel
Copy link
Author

mmattel commented Oct 13, 2022

You should close when the release is published and not when the release is somewhere on the road - or you link to the PR that fixes the issue... How else can we track?

@xmedeko
Copy link

xmedeko commented Oct 14, 2022

@hugocostadev @mmattel I think it sufficient to write the release exact number e.g. 5.2.0 and everybody may check if it has been released or not. It's useful e.g. when a release is delayed.

@hugocostadev
Copy link
Contributor

Sorry, the release is the 5.2: https://github.com/RocketChat/Rocket.Chat/releases/tag/5.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants